Hi Tomi,
On Mon, Aug 26, 2019 at 02:39:25PM +0300, Tomi Valkeinen wrote:
On 20/08/2019 04:16, Laurent Pinchart wrote:
In preparation of adding DRM bridge support to the hdmi4 encoder code, rework the EDID read to isolate data read.
Signed-off-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
drivers/gpu/drm/omapdrm/dss/hdmi4.c | 94 +++++++++++++++--------- drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 59 +++------------ drivers/gpu/drm/omapdrm/dss/hdmi4_core.h | 4 +- 3 files changed, 73 insertions(+), 84 deletions(-)
I find this (and the next) patch a bit difficult to review. Can you explain a bit more what the purpose and the change is?
The commit message in v3 will read
drm/omap: hdmi5: Rework EDID read to isolate data read
In preparation of adding DRM bridge support to the hdmi5 encoder code, rework the EDID read to isolate data read.
The hdmi_read_edid() function is the main entry point. It performs all initialisation steps required prior to reading the EDID (such as ensuring the device is powered on), as well as corresponding cleanup steps afterwards. EDID read itself is handled by hdmi_read_edid_data() that calls the hdmi5_core_ddc_read() function to read individual blocks.
This new code architecture will allow reusing hdmi_read_edid() and hdmi5_core_ddc_read() for the drm_bridge EDID read implementation, while swapping out hdmi_read_edid_data() for the DRM drm_do_get_edid() function.