Hi Igor,
Thanks for your patch!
Às 17:45 de 04/04/22, Igor Torrente escreveu:
Currently, the memory to the composition frame is being allocated using the kzmalloc. This comes with the limitation of maximum size of one page size(which in the x86_64 is 4Kb and 4MB for default and hugepage respectively).
Somes test of igt (e.g. kms_plane@pixel-format) uses more than 4MB when testing some pixel formats like ARGB16161616 and the following error were showing up when running kms_plane@plane-panning-bottom-right*:
[drm:vkms_composer_worker [vkms]] *ERROR* Cannot allocate memory for output frame.
This problem is addessed by allocating the memory using kvzalloc that
addessed -> addressed
OTOH, I would write this in imperative mood, as in "Address this by allocating..." or "Fix this..."
circunvents this limitation.
circunvents -> circumvents
V5: Improve the commit message and drop the debugging issues in VKMS TO-DO(Melissa Wen).
Patch changelog are very useful for the mailing list, but not very useful for the git log. For that reason, I usually put this right after the --- in the patch, so the log will be dropped when the patch is applied.
Those comment applies for the rest of your series.
Reviewed-by: Melissa Wen mwen@igalia.com Signed-off-by: Igor Torrente igormtorrente@gmail.com