Re: [PATCH 4/4] drm/crtc: add drmm_crtc_alloc_with_planes()

26 Aug 2020


      Hi Philipp,
I love your patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip linus/master v5.9-rc2 next-20200826]
[cannot apply to tegra-drm/drm/tegra/for-next drm-exynos/exynos-drm-next drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:    https://github.com/0day-ci/linux/commits/Philipp-Zabel/drm-add-drmm_encoder_...
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: arm-randconfig-r001-20200826 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot lkp@intel.com
All warnings (new ones prefixed by >>):
drivers/gpu/drm/drm_crtc.c: In function '__drm_crtc_init_with_planes':
...
...
drivers/gpu/drm/drm_crtc.c:267:3: warning: function '__drm_crtc_init_with_planes' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
267 |   crtc->name = kvasprintf(GFP_KERNEL, name, ap);
         |   ^~~~
# https://github.com/0day-ci/linux/commit/236b7bc44ae0fdecc8e80c5aba0655ca14fd...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Philipp-Zabel/drm-add-drmm_encoder_alloc/20200826-203629
git checkout 236b7bc44ae0fdecc8e80c5aba0655ca14fdfb23
vim +267 drivers/gpu/drm/drm_crtc.c
35f8cc3b9a92c66 Gustavo Padovan e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser e954f77f6330028 Simon Ser 236b7bc44ae0fde Philipp Zabel e13161af80c185e Matt Roper fc1d3e44ef7c1db Matt Roper f98828769c8838f Ville Syrjälä 236b7bc44ae0fde Philipp Zabel f453ba0460742ad Dave Airlie 51fd371bbaf9401 Rob Clark 6bfc56aa89f963b Ville Syrjälä 6bfc56aa89f963b Ville Syrjälä 522cf91f30cb010 Benjamin Gaignard 522cf91f30cb010 Benjamin Gaignard 522cf91f30cb010 Benjamin Gaignard 2a8d3eac3d6e116 Ville Syrjälä 2a8d3eac3d6e116 Ville Syrjälä 2a8d3eac3d6e116 Ville Syrjälä 2a8d3eac3d6e116 Ville Syrjälä ba1f665f161ce11 Haneen Mohammed ba1f665f161ce11 Haneen Mohammed ba1f665f161ce11 Haneen Mohammed ba1f665f161ce11 Haneen Mohammed f453ba0460742ad Dave Airlie f453ba0460742ad Dave Airlie f453ba0460742ad Dave Airlie 3b24f7d67581659 Daniel Vetter 3b24f7d67581659 Daniel Vetter 3b24f7d67581659 Daniel Vetter 51fd371bbaf9401 Rob Clark 2135ea7aafa26b6 Thierry Reding 6bfc56aa89f963b Ville Syrjälä baf698b0496e93f Daniel Vetter f453ba0460742ad Dave Airlie fa3ab4c2113c74a Ville Syrjälä fa3ab4c2113c74a Ville Syrjälä fa3ab4c2113c74a Ville Syrjälä fa3ab4c2113c74a Ville Syrjälä fa3ab4c2113c74a Ville Syrjälä fa3ab4c2113c74a Ville Syrjälä fa3ab4c2113c74a Ville Syrjälä 7c8f6d2577c7565 Dave Airlie fa3ab4c2113c74a Ville Syrjälä fa3ab4c2113c74a Ville Syrjälä fa3ab4c2113c74a Ville Syrjälä 6d6003c4b613c93 Gustavo Padovan 6d6003c4b613c93 Gustavo Padovan 6d6003c4b613c93 Gustavo Padovan 6d6003c4b613c93 Gustavo Padovan 6d6003c4b613c93 Gustavo Padovan bffd9de02977025 Paulo Zanoni bffd9de02977025 Paulo Zanoni 51fd371bbaf9401 Rob Clark 490d3d1b91201fd Chris Wilson 6bfc56aa89f963b Ville Syrjälä e13161af80c185e Matt Roper fc1d3e44ef7c1db Matt Roper 7abc7d47510c75d Rob Clark 6a52193bd0dd683 Ville Syrjälä 7abc7d47510c75d Rob Clark 6a52193bd0dd683 Ville Syrjälä e13161af80c185e Matt Roper 9edbf1fa600a2ef Tomeu Vizoso 9edbf1fa600a2ef Tomeu Vizoso 9edbf1fa600a2ef Tomeu Vizoso 9edbf1fa600a2ef Tomeu Vizoso 9edbf1fa600a2ef Tomeu Vizoso 9edbf1fa600a2ef Tomeu Vizoso eab3bbeffd15212 Daniel Vetter eab3bbeffd15212 Daniel Vetter 955f3c334f0fb2b Daniel Stone beaf5af48034c9e Gustavo Padovan beaf5af48034c9e Gustavo Padovan 1398958cfd8d331 Nicholas 1398958cfd8d331 Nicholas eab3bbeffd15212 Daniel Vetter eab3bbeffd15212 Daniel Vetter baf698b0496e93f Daniel Vetter f453ba0460742ad Dave Airlie 236b7bc44ae0fde Philipp Zabel

2016-12-06  207 2020-05-21  208  /** 2020-05-21  209   * DOC: standard CRTC properties 2020-05-21  210   * 2020-05-21  211   * DRM CRTCs have a few standardized properties: 2020-05-21  212   * 2020-05-21  213   * ACTIVE: 2020-05-21  214   * 	Atomic property for setting the power state of the CRTC. When set to 1 2020-05-21  215   * 	the CRTC will actively display content. When set to 0 the CRTC will be 2020-05-21  216   * 	powered off. There is no expectation that user-space will reset CRTC 2020-05-21  217   * 	resources like the mode and planes when setting ACTIVE to 0. 2020-05-21  218   * 2020-05-21  219   * 	User-space can rely on an ACTIVE change to 1 to never fail an atomic 2020-05-21  220   * 	test as long as no other property has changed. If a change to ACTIVE 2020-05-21  221   * 	fails an atomic test, this is a driver bug. For this reason setting 2020-05-21  222   * 	ACTIVE to 0 must not release internal resources (like reserved memory 2020-05-21  223   * 	bandwidth or clock generators). 2020-05-21  224   * 2020-05-21  225   * 	Note that the legacy DPMS property on connectors is internally routed 2020-05-21  226   * 	to control this property for atomic drivers. 2020-05-21  227   * MODE_ID: 2020-05-21  228   * 	Atomic property for setting the CRTC display timings. The value is the 2020-05-21  229   * 	ID of a blob containing the DRM mode info. To disable the CRTC, 2020-05-21  230   * 	user-space must set this property to 0. 2020-05-21  231   * 2020-05-21  232   * 	Setting MODE_ID to 0 will release reserved resources for the CRTC. 2020-05-21  233   */ 2020-05-21  234 2020-08-26  235  static int __drm_crtc_init_with_planes(struct drm_device *dev, struct drm_crtc *crtc, 2014-04-01  236  				       struct drm_plane *primary, 2014-06-10  237  				       struct drm_plane *cursor, 2015-12-09  238  				       const struct drm_crtc_funcs *funcs, 2020-08-26  239  				       const char *name, va_list ap) 2008-11-07  240  { 2013-11-19  241  	struct drm_mode_config *config = &dev->mode_config; 2012-03-13  242  	int ret; 2012-03-13  243 2015-03-17  244  	WARN_ON(primary && primary->type != DRM_PLANE_TYPE_PRIMARY); 2015-03-17  245  	WARN_ON(cursor && cursor->type != DRM_PLANE_TYPE_CURSOR); 2015-03-17  246 2018-01-25  247  	/* crtc index is used with 32bit bitmasks */ 2018-01-25  248  	if (WARN_ON(config->num_crtc >= 32)) 2018-01-25  249  		return -EINVAL; 2018-01-25  250 2018-05-25  251  	WARN_ON(drm_drv_uses_atomic_modeset(dev) && 2018-05-25  252  		(!funcs->atomic_destroy_state || 2018-05-25  253  		 !funcs->atomic_duplicate_state)); 2018-05-25  254 2008-11-07  255  	crtc->dev = dev; 2008-11-07  256  	crtc->funcs = funcs; 2008-11-07  257 2016-06-08  258  	INIT_LIST_HEAD(&crtc->commit_list); 2016-06-08  259  	spin_lock_init(&crtc->commit_lock); 2016-06-08  260 2013-11-19  261  	drm_modeset_lock_init(&crtc->mutex); 2017-02-28  262  	ret = drm_mode_object_add(dev, &crtc->base, DRM_MODE_OBJECT_CRTC); 2012-03-13  263  	if (ret) 2014-11-12  264  		return ret; 2008-11-07  265 2015-12-08  266  	if (name) { 2015-12-08 @267  		crtc->name = kvasprintf(GFP_KERNEL, name, ap); 2015-12-08  268  	} else { 2015-12-08  269  		crtc->name = kasprintf(GFP_KERNEL, "crtc-%d", 2015-12-08  270  				       drm_num_crtcs(dev)); 2015-12-08  271  	} 2015-12-08  272  	if (!crtc->name) { 2016-04-15  273  		drm_mode_object_unregister(dev, &crtc->base); 2015-12-08  274  		return -ENOMEM; 2015-12-08  275  	} 2015-12-08  276 2016-11-15  277  	crtc->fence_context = dma_fence_context_alloc(1); 2016-11-15  278  	spin_lock_init(&crtc->fence_lock); 2016-11-15  279  	snprintf(crtc->timeline_name, sizeof(crtc->timeline_name), 2016-11-15  280  		 "CRTC:%d-%s", crtc->base.id, crtc->name); 2016-11-15  281 2012-05-15  282  	crtc->base.properties = &crtc->properties; 2012-05-15  283 2013-11-19  284  	list_add_tail(&crtc->head, &config->crtc_list); 2016-05-27  285  	crtc->index = config->num_crtc++; 2012-03-13  286 2014-04-01  287  	crtc->primary = primary; 2014-06-10  288  	crtc->cursor = cursor; 2016-11-05  289  	if (primary && !primary->possible_crtcs) 2018-06-26  290  		primary->possible_crtcs = drm_crtc_mask(crtc); 2016-11-05  291  	if (cursor && !cursor->possible_crtcs) 2018-06-26  292  		cursor->possible_crtcs = drm_crtc_mask(crtc); 2014-04-01  293 2016-10-06  294  	ret = drm_crtc_crc_init(crtc); 2016-10-06  295  	if (ret) { 2016-10-06  296  		drm_mode_object_unregister(dev, &crtc->base); 2016-10-06  297  		return ret; 2016-10-06  298  	} 2016-10-06  299 2015-01-22  300  	if (drm_core_check_feature(dev, DRIVER_ATOMIC)) { 2015-01-22  301  		drm_object_attach_property(&crtc->base, config->prop_active, 0); 2015-05-25  302  		drm_object_attach_property(&crtc->base, config->prop_mode_id, 0); 2016-11-16  303  		drm_object_attach_property(&crtc->base, 2016-11-16  304  					   config->prop_out_fence_ptr, 0); Kazlauskas 2018-10-04  305  		drm_object_attach_property(&crtc->base, Kazlauskas 2018-10-04  306  					   config->prop_vrr_enabled, 0); 2015-01-22  307  	} 2015-01-22  308 2014-11-12  309  	return 0; 2008-11-07  310  } 2020-08-26  311
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Re: [PATCH 4/4] drm/crtc: add drmm_crtc_alloc_with_planes()