Re: [PATCH libdrm 0/9] Rework remaining tests

On 24/03/15 23:20, Jan Vesely wrote:

On Sun, 2015-03-22 at 22:03 +0000, Emil Velikov wrote:

...

This series covers

• Remove the hackish "include xf86drmfoo.c" from dristat
• Extract the remaining two xf86drmfoo.c tests to standalone ones
• beat them into shape, and
• wire them up to make check.

I finished going through the series. Feel free to ignore the internal header suggestions, I don;t think the risk of desynchronizing structures in test and implementation is real since few ppl will touch it anyway.

drmHash test looks weird after cleanup. other than that looks good

Thanks I'll update the series (incorporating all of your comments), drop patch 1 for now, and send it out in a bit.

-Emil