Hi ZubairLK: On 2014年11月11日 22:36, Zubair Lutfullah Kakakhel wrote:
Hi Andy,
On 11/11/14 12:54, Andy Yan wrote:
From: Yakir Yang ykk@rock-chips.com
keep the connector & birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c
Is there a reason for this separation? Keeping encoder in platform files? If yes, then the commit message should explain that.
in the encoder, most operation are platform specific, such as mux to select which crtc is used, set panel format etc, these operation complete by platform specific interface
Signed-off-by: Andy Yan andy.yan@rock-chips.com Signed-off-by: Yakir Yang ykk@rock-chips.com
Changes in v7: None Changes in v6:
- move some modification from patch#5
Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None
drivers/gpu/drm/bridge/dw_hdmi.c | 228 +++++++++++++++------------------- drivers/staging/imx-drm/dw_hdmi-imx.c | 145 ++++++++++++++------- include/drm/bridge/dw_hdmi.h | 13 +- 3 files changed, 199 insertions(+), 187 deletions(-)
Regards ZubairLK
Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip