Re: [PATCH 02/11] drm: bridge: samsung-dsim: Handle platform init via driver_data

On 08.04.2022 18:20, Jagan Teki wrote:

In order to make a common Samsung DSIM bridge driver some platform specific glue code needs to maintain separately as it is hard to maintain platform specific glue and conventional component_ops on the drm bridge drivers side.

This patch is trying to support that glue code initialization and invocation in the form of platform_init flag in driver_data.

So, the platforms which enable platform_init flags will handle all platform specific initialization via samsung_dsim_plat_probe.

The Platform probe is responsible to

• initialize samsung_dsim_plat_data and install hooks
• initialize component_ops
• preserve samsung_dsim structure pointer

v1:

• use platform_init instead of exynos_specific
• handle component_ops in glue code

Signed-off-by: Jagan Teki jagan@amarulasolutions.com

drivers/gpu/drm/bridge/samsung-dsim.c | 20 ++++++++++++++++---- include/drm/bridge/samsung-dsim.h | 1 + 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c index ee5d7e5518a6..0e6a5d1c7e4e 100644 --- a/drivers/gpu/drm/bridge/samsung-dsim.c +++ b/drivers/gpu/drm/bridge/samsung-dsim.c @@ -370,6 +370,7 @@ static const struct samsung_dsim_driver_data exynos3_dsi_driver_data = { .wait_for_reset = 1, .num_bits_resol = 11, .reg_values = reg_values,

• .platform_init = true, };

  static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = {

@@ -382,6 +383,7 @@ static const struct samsung_dsim_driver_data exynos4_dsi_driver_data = { .wait_for_reset = 1, .num_bits_resol = 11, .reg_values = reg_values,

• .platform_init = true, };

  static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = {

@@ -392,6 +394,7 @@ static const struct samsung_dsim_driver_data exynos5_dsi_driver_data = { .wait_for_reset = 1, .num_bits_resol = 11, .reg_values = reg_values,

• .platform_init = true, };

  static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = {

@@ -403,6 +406,7 @@ static const struct samsung_dsim_driver_data exynos5433_dsi_driver_data = { .wait_for_reset = 0, .num_bits_resol = 12, .reg_values = exynos5433_reg_values,

• .platform_init = true, };

  static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = {

@@ -414,6 +418,7 @@ static const struct samsung_dsim_driver_data exynos5422_dsi_driver_data = { .wait_for_reset = 1, .num_bits_resol = 12, .reg_values = exynos5422_reg_values,

• .platform_init = true, };

  static const struct of_device_id samsung_dsim_of_match[] = {

@@ -1565,12 +1570,16 @@ static int samsung_dsim_probe(struct platform_device *pdev) dsi->bridge.of_node = dev->of_node; dsi->bridge.type = DRM_MODE_CONNECTOR_DSI;

• dsi->plat_data = samsung_dsim_plat_probe(dsi);
• if (IS_ERR(dsi->plat_data)) {

• if (dsi->driver_data->platform_init) {

• dsi->plat_data = samsung_dsim_plat_probe(dsi);
  

  ret = PTR_ERR(dsi->plat_data);

ret = IS_ERR(dsi->plat_data) ? PTR_ERR(dsi->plat_data) : 0;

otherwise it always fails.

• goto err_disable_runtime;
  

• } else {

• ret = mipi_dsi_host_register(&dsi->dsi_host);
  

  }

• if (ret)

• goto err_disable_runtime;
  

• return 0;

  err_disable_runtime:

@@ -1585,7 +1594,10 @@ static int samsung_dsim_remove(struct platform_device *pdev)

pm_runtime_disable(&pdev->dev);

• samsung_dsim_plat_remove(dsi);

• if (dsi->driver_data->platform_init)

• samsung_dsim_plat_remove(dsi);
  

• else

• mipi_dsi_host_unregister(&dsi->dsi_host);
  
  

  return 0; }

diff --git a/include/drm/bridge/samsung-dsim.h b/include/drm/bridge/samsung-dsim.h index 59a43f9c4477..eca7eacb5910 100644 --- a/include/drm/bridge/samsung-dsim.h +++ b/include/drm/bridge/samsung-dsim.h @@ -39,6 +39,7 @@ struct samsung_dsim_driver_data { unsigned int wait_for_reset; unsigned int num_bits_resol; const unsigned int *reg_values;

• bool platform_init; };

  struct samsung_dsim_host_ops {

Best regards