Re: [PATCH v4 1/9] dt-bindings: display: renesas,cmm: Add R-Car CMM documentation

On Fri, Sep 06, 2019 at 03:54:28PM +0200, Jacopo Mondi wrote:

Add device tree bindings documentation for the Renesas R-Car Display Unit Color Management Module.

CMM is the image enhancement module available on each R-Car DU video channel on R-Car Gen2 and Gen3 SoCs (V3H and V3M excluded).

Signed-off-by: Jacopo Mondi jacopo+renesas@jmondi.org

.../bindings/display/renesas,cmm.yaml | 64 +++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/renesas,cmm.yaml

diff --git a/Documentation/devicetree/bindings/display/renesas,cmm.yaml b/Documentation/devicetree/bindings/display/renesas,cmm.yaml new file mode 100644 index 000000000000..9e5922689cd7 --- /dev/null +++ b/Documentation/devicetree/bindings/display/renesas,cmm.yaml @@ -0,0 +1,64 @@ +# SPDX-License-Identifier: GPL-2.0

For new bindings:

GPL-2.0-only OR BSD-2-Clause

+%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/renesas,cmm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Renesas R-Car Color Management Module (CMM)

+maintainers:

• • Laurent Pinchart laurent.pinchart@ideasonboard.com
• • Kieran Bingham kieran.bingham+renesas@ideasonboard.com
• • Jacopo Mondi jacopo+renesas@jmondi.org

+description: |+

• Renesas R-Car color management module connected to R-Car DU video channels.
• It provides image enhancement functions such as 1-D look-up tables (LUT),
• 3-D look-up tables (CMU), 1D-histogram generation (HGO), and color
• space conversion (CSC).

+properties:

• compatible:
• items:

•  - enum:
  

•    - renesas,r8a7795-cmm
  

•    - renesas,r8a7796-cmm
  

•    - renesas,r8a77965-cmm
  

•    - renesas,r8a77990-cmm
  

•    - renesas,r8a77995-cmm
  

•  - enum:
  

•    - renesas,rcar-gen3-cmm
  

•    - renesas,rcar-gen2-cmm
  

This allows 10 valid cases when I imagine there's only really 5. I'm okay leaving it, but might be better to split into 2 under a 'oneOf'.

I imagine there will be a lot of these for Renesas, so just be consistent.

• reg:
• maxItems: 1
• clocks:
• maxItems: 1
• resets:
• maxItems: 1
• power-domains:
• maxItems: 1

+required:

• • compatible
• • reg
• • clocks
• • resets
• • power-domains

+additionalProperties: false

+examples:

• • |
• #include <dt-bindings/clock/r8a7796-cpg-mssr.h>
• #include <dt-bindings/power/r8a7796-sysc.h>
• cmm0: cmm@fea40000 {

•     compatible = "renesas,r8a7796-cmm";
  

•     reg = <0 0xfea40000 0 0x1000>;
  

•     power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
  

•     clocks = <&cpg CPG_MOD 711>;
  

•     resets = <&cpg 711>;
  

• };

-- 2.23.0