Re: [PATCH v3 1/2] arm64: dts: qcom: sc7280: Add gpu support

Quoting Akhil P Oommen (2021-07-28 04:54:01)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi index 029723a..c88f366 100644 --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi @@ -592,6 +593,85 @@ qcom,bcm-voters = <&apps_bcm_voter>; };

•           gpu@3d00000 {
  

•                   compatible = "qcom,adreno-635.0", "qcom,adreno";
  

•                   #stream-id-cells = <16>;
  

•                   reg = <0 0x03d00000 0 0x40000>,
  

•                         <0 0x03d9e000 0 0x1000>,
  

•                         <0 0x03d61000 0 0x800>;
  

•                   reg-names = "kgsl_3d0_reg_memory",
  

•                               "cx_mem",
  

•                               "cx_dbgc";
  

•                   interrupts = <GIC_SPI 300 IRQ_TYPE_LEVEL_HIGH>;
  

•                   iommus = <&adreno_smmu 0 0x401>;
  

•                   operating-points-v2 = <&gpu_opp_table>;
  

•                   qcom,gmu = <&gmu>;
  

•                   interconnects = <&gem_noc MASTER_GFX3D 0 &mc_virt SLAVE_EBI1 0>;
  

•                   interconnect-names = "gfx-mem";
  

•                   gpu_opp_table: opp-table {
  

•                           compatible = "operating-points-v2";
  

•                           opp-550000000 {
  

•                                   opp-hz = /bits/ 64 <550000000>;
  

•                                   opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>;
  

•                                   opp-peak-kBps = <6832000>;
  

•                           };
  

•                           opp-450000000 {
  

Why is 450000000 after 550000000? Is it on purpose? If not intended please sort by frequency.

•                                   opp-hz = /bits/ 64 <450000000>;
  

•                                   opp-level = <RPMH_REGULATOR_LEVEL_SVS>;
  

•                                   opp-peak-kBps = <4068000>;
  

•                           };
  

•                           opp-315000000 {
  

•                                   opp-hz = /bits/ 64 <315000000>;
  

•                                   opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>;
  

•                                   opp-peak-kBps = <1804000>;
  

•                           };
  

•                   };
  

•           };