Am 2021-06-09 um 3:23 p.m. schrieb Matthew Wilcox:
On Mon, Jun 07, 2021 at 03:42:19PM -0500, Alex Sierra wrote:
+++ b/include/linux/dax.h @@ -243,6 +243,16 @@ static inline bool dax_mapping(struct address_space *mapping) return mapping->host && IS_DAX(mapping->host); }
+static inline bool dax_layout_is_idle_page(struct page *page) +{
- return page_ref_count(page) == 1;
+}
We already have something called an idle page, and that's quite a different thing from this. How about dax_page_unused() (it's a use count, so once it's got down to its minimum value, it's unused)?
Hi Matthew,
Thank you very much for your feedback. This patch looks straight-forward enough, but do we need the filesystem maintainers to review this as well? I guess we should CC the linux-ext4 and linux-xfs mailing lists in the next revision.
Hi Ralph,
Are you OK if we update your patch with this suggestion?
Thanks, Felix