Hi Mahesh,
Thank you for the patch.
On Monday, 2 July 2018 14:07:28 EEST Mahesh Kumar wrote:
This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680.
Don't wait for first CRC during crtc_crc_open. It avoids one frame wait during open. If application want to wait after read call, it can use poll/read blocking read() call.
Suggested-by: Ville Syrjälä ville.syrjala@linux.intel.com Signed-off-by: Mahesh Kumar mahesh1.kumar@intel.com Cc: dri-devel@lists.freedesktop.org Cc: Tomeu Vizoso tomeu.vizoso@collabora.com
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
drivers/gpu/drm/drm_debugfs_crc.c | 16 ---------------- 1 file changed, 16 deletions(-)
diff --git a/drivers/gpu/drm/drm_debugfs_crc.c b/drivers/gpu/drm/drm_debugfs_crc.c index 739a813b4b09..add35b77165b 100644 --- a/drivers/gpu/drm/drm_debugfs_crc.c +++ b/drivers/gpu/drm/drm_debugfs_crc.c @@ -226,24 +226,8 @@ static int crtc_crc_open(struct inode *inode, struct file *filep) if (ret) goto err;
- spin_lock_irq(&crc->lock);
- /*
* Only return once we got a first frame, so userspace doesn't have to* guess when this particular piece of HW will be ready to start* generating CRCs.*/- ret = wait_event_interruptible_lock_irq(crc->wq,
crtc_crc_data_count(crc),crc->lock);- spin_unlock_irq(&crc->lock);
- if (ret)
goto err_disable;- return 0;
-err_disable:
- crtc->funcs->set_crc_source(crtc, NULL);
err: spin_lock_irq(&crc->lock); crtc_crc_cleanup(crc);