Re: [PATCH v3 3/4] drm/bridge: Add devm_drm_bridge_add()

Hi,

On Tue, May 10, 2022 at 12:29:43PM -0700, Douglas Anderson wrote:

This adds a devm managed version of drm_bridge_add(). Like other "devm" function listed in drm_bridge.h, this function takes an explicit "dev" to use for the lifetime management. A few notes:

• In general we have a "struct device" for bridges that makes a good candidate for where the lifetime matches exactly what we want.
• The "bridge->dev->dev" device appears to be the encoder device. That's not the right device to use for lifetime management.

Suggested-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org Signed-off-by: Douglas Anderson dianders@chromium.org

If we are to introduce more managed helpers, I think it'd be wiser to introduce them as DRM-managed, and not device managed.

Otherwise, you'll end up in a weird state when a device has been removed but the DRM device is still around.

Maxime