Hi Alexey,
On 03-03-2017 13:27, Alexey Brodkin wrote:
So if I understood you correct here what I really need is just to get rid of existing check, right? I.e. the following is to be in v2 respin: ------------------------------->8------------------------------- diff --git a/drivers/gpu/drm/arc/arcpgu_crtc.c b/drivers/gpu/drm/arc/arcpgu_crtc.c index ad9a95916f1f..86f1555914e8 100644 --- a/drivers/gpu/drm/arc/arcpgu_crtc.c +++ b/drivers/gpu/drm/arc/arcpgu_crtc.c @@ -129,20 +129,6 @@ static void arc_pgu_crtc_disable(struct drm_crtc *crtc) ~ARCPGU_CTRL_ENABLE_MASK); }
-static int arc_pgu_crtc_atomic_check(struct drm_crtc *crtc,
struct drm_crtc_state *state)-{
struct arcpgu_drm_private *arcpgu = crtc_to_arcpgu_priv(crtc);struct drm_display_mode *mode = &state->adjusted_mode;long rate, clk_rate = mode->clock * 1000;rate = clk_round_rate(arcpgu->clk, clk_rate);if (rate != clk_rate)return -EINVAL;return 0;-}
static void arc_pgu_crtc_atomic_begin(struct drm_crtc *crtc, struct drm_crtc_state *state) { @@ -165,7 +151,6 @@ static const struct drm_crtc_helper_funcs arc_pgu_crtc_helper_funcs = { .disable = arc_pgu_crtc_disable, .prepare = arc_pgu_crtc_disable, .commit = arc_pgu_crtc_enable,
.atomic_check = arc_pgu_crtc_atomic_check, .atomic_begin = arc_pgu_crtc_atomic_begin,}; ------------------------------->8-------------------------------
I don't think you can remove the check entirely as this will make any mode be accepted, right?
Best regards, Jose Miguel Abreu