The various for_each device_node iterators performs an of_node_get on each iteration, so a break out of the loop requires an of_node_put.
The complete semantic patch that fixes this problem is (http://coccinelle.lip6.fr):
// <smpl> @r@ local idexpression n; expression e1,e2; iterator name for_each_node_by_name, for_each_node_by_type, for_each_compatible_node, for_each_matching_node, for_each_matching_node_and_match, for_each_child_of_node, for_each_available_child_of_node, for_each_node_with_property; iterator i; statement S; expression list [n1] es; @@
( ( for_each_node_by_name(n,e1) S | for_each_node_by_type(n,e1) S | for_each_compatible_node(n,e1,e2) S | for_each_matching_node(n,e1) S | for_each_matching_node_and_match(n,e1,e2) S | for_each_child_of_node(e1,n) S | for_each_available_child_of_node(e1,n) S | for_each_node_with_property(n,e1) S ) & i(es,n,...) S )
@@ local idexpression r.n; iterator r.i; expression e; expression list [r.n1] es; @@
i(es,n,...) { ... ( of_node_put(n); | e = n | return n; | + of_node_put(n); ? return ...; ) ... }
@@ local idexpression r.n; iterator r.i; expression e; expression list [r.n1] es; @@
i(es,n,...) { ... ( of_node_put(n); | e = n | + of_node_put(n); ? break; ) ... } ... when != n
@@ local idexpression r.n; iterator r.i; expression e; identifier l; expression list [r.n1] es; @@
i(es,n,...) { ... ( of_node_put(n); | e = n | + of_node_put(n); ? goto l; ) ... } ... l: ... when != n// </smpl>
---
drivers/bluetooth/btmrvl_main.c | 5 ++++- drivers/gpu/drm/tegra/dc.c | 4 +++- drivers/gpu/host1x/bus.c | 4 +++- drivers/leds/leds-88pm860x.c | 1 + drivers/leds/leds-bcm6328.c | 4 +++- drivers/leds/leds-bcm6358.c | 4 +++- drivers/leds/leds-powernv.c | 8 ++++++-- drivers/pinctrl/pinctrl-at91.c | 5 ++++- drivers/soc/ti/knav_qmss_queue.c | 3 +++ 9 files changed, 30 insertions(+), 8 deletions(-)