On Sun, Jan 19, 2014 at 07:58:45PM +0100, Jean-Francois Moine wrote:
This patch fixes the ENABLE_SPACE register, the value of which was inverted.
Signed-off-by: Jean-Francois Moine moinejf@free.fr
I've researched the change to PLL_SERIAL_2, and this is correct. I think your change to REG_ENABLE_SPACE is also correct. This looks like a bug fix to me, so maybe consider having it applied to previous kernel versions as well?
Also... please try putting yourself in the position of a reviewer of your own patches - read the patch and then read the description, and ask whether the description is adequate for the patch... the description talks just about the ENABLE_SPACE register. But what about the PLL_SERIAL_2 register changes? They're *totally* not described.
Hence...
Tested-by: Russell King rmk+kernel@arm.linux.org.uk
and no acked-by.