Hi,
On 6/9/20 10:13 PM, Dmitry Osipenko wrote:
Tegra EMC driver was turned into a regular kernel driver, it also could be compiled as a loadable kernel module now. Hence EMC clock isn't guaranteed to be available and clk_get("emc") may return -EPROBE_DEFER and there is no good reason to spam KMSG with a error about missing EMC clock in this case, so let's silence the deferred probe error.
Signed-off-by: Dmitry Osipenko digetx@gmail.com
drivers/devfreq/tegra30-devfreq.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c index e94a27804c20..423dd35c95b3 100644 --- a/drivers/devfreq/tegra30-devfreq.c +++ b/drivers/devfreq/tegra30-devfreq.c @@ -801,9 +801,12 @@ static int tegra_devfreq_probe(struct platform_device *pdev) }
tegra->emc_clock = devm_clk_get(&pdev->dev, "emc");
- if (IS_ERR(tegra->emc_clock)) {
dev_err(&pdev->dev, "Failed to get emc clock\n");return PTR_ERR(tegra->emc_clock);
err = PTR_ERR_OR_ZERO(tegra->emc_clock);
if (err) {
if (err != -EPROBE_DEFER)dev_err(&pdev->dev, "Failed to get emc clock: %d\n",err);return err;}
err = platform_get_irq(pdev, 0);
As I commented on patch10, I recommend that you add the Tegra EMC driver commit information into patch description and Looks good to me.