On Tue, 12 Oct 2021, Jani Nikula jani.nikula@linux.intel.com wrote:
On Mon, 11 Oct 2021, Matthew Brost matthew.brost@intel.com wrote:
On Mon, Oct 11, 2021 at 08:51:03PM +0530, Thanneeru Srinivasulu wrote:
Replace DRM_ERROR with CT_PROBE_ERROR to report early CTB failures.
Signed-off-by: Thanneeru Srinivasulu thanneeru.srinivasulu@intel.com
Reviewed-by: Matthew Brost matthew.brost@intel.com
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c index 0a3504bc0b61..83764db0fd6d 100644 --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c @@ -191,8 +191,8 @@ static int ct_register_buffer(struct intel_guc_ct *ct, u32 type, err = guc_action_register_ct_buffer(ct_to_guc(ct), type, desc_addr, buff_addr, size); if (unlikely(err))
CT_ERROR(ct, "Failed to register %s buffer (%pe)\n",guc_ct_buffer_type_to_str(type), ERR_PTR(err));
CT_PROBE_ERROR(ct, "Failed to register %s buffer (%pe)\n",guc_ct_buffer_type_to_str(type), ERR_PTR(err));Please tell me why we are adding not just i915-specific logging helpers, but file specific ones?
To be honest I'd like to see all of the CT_ERROR, CT_DEBUG, CT_PROBE_ERROR macros just gone.
For that matter, why has GEM_BUG_ON spread like a disease to display and intel_uncore.c too?
BR, Jani.
BR, Jani.
return err; }
-- 2.25.1