Hi Icenowy,
Thank you for the patch.
On Thursday, 18 October 2018 10:33:22 EEST Icenowy Zheng wrote:
The ANX6345 is an ultra-low power DisplayPort/eDP transmitter designed for portable devices.
Add a binding document for it.
Signed-off-by: Icenowy Zheng icenowy@aosc.io
.../bindings/display/bridge/anx6345.txt | 39 +++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx6345.txt
diff --git a/Documentation/devicetree/bindings/display/bridge/anx6345.txt b/Documentation/devicetree/bindings/display/bridge/anx6345.txt new file mode 100644 index 000000000000..0689d4eb5f65 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/anx6345.txt @@ -0,0 +1,39 @@ +Analogix ANX6345 eDP Transmitter +--------------------------------
+The ANX6345 is an ultra-low power Full-HD eDP transmitter designed for +portable devices.
+Required properties:
- compatible : "analogix,anx6345"
- reg : I2C address of the device
- reset-gpios : Which GPIO to use for reset
+Optional properties:
- dvdd12-supply : Regulator for 1.2V digital core power.
- dvdd25-supply : Regulator for 2.5V digital core power.
Shouldn't these to supplies be mandatory ?
- panel-supply : Regulator for the power of the panel.
Shouldn't the panel supply for specified in the DT node of the panel ?
- edid : verbatim EDID data block describing attached
panel, only used when the panel has no EDID info.
This should also be specified in the panel DT node.
- Video port for RGB input, using the DT bindings defined in [1].
I think you should also add a port for the output.
+[1]: Documentation/devicetree/bindings/media/video-interfaces.txt
+Example:
+anx6345: anx6345@38 {
- compatible = "analogix,anx6345";
- reg = <0x38>;
- reset-gpios = <&pio 3 24 GPIO_ACTIVE_HIGH>; /* PD24 */
- panel-supply = <®_dc1sw>;
- dvdd25-supply = <®_dldo2>;
- dvdd12-supply = <®_fldo1>;
- port {
anx6345_in: endpoint {remote-endpoint = <&tcon0_out_anx6345>;};- };
+};