On 8 August 2014 02:00, David Herrmann dh.herrmann@gmail.com wrote:
Hi
On Thu, Aug 7, 2014 at 3:04 PM, Chris Wilson chris@chris-wilson.co.uk wrote:
Despite the claims of
commit 48ba813701eb14b3008edefef4a0789b328e278c Author: David Herrmann dh.herrmann@gmail.com Date: Tue Jul 22 18:46:09 2014 +0200
drm: drop redundant drm_file->is_masterdrm_file->is_master is not synomous with having drm_file->master == drm_file->minor->master. This is because drm_file->master is the same for all drm_files of the same generation and so when there is a master, every drm_file believes itself to be the master. Confusion ensues and things go pear shaped when one file is closed and there is no master anymore.
Uagh, embarrassing. A revert is fine with me, but I'll try to review your patch once I get home.
At this point I'll just revert, though I do like the wrapper instead of checking the flag, but its late in the day.
Dave.