On 2019-10-10 21:30:35 [+0100], Chris Wilson wrote:
| spin_lock_irq(&rq->engine->active.lock); | list_del(&rq->sched.link); | spin_unlock_irq(&rq->engine->active.lock); | | spin_lock_irq(&rq->lock); | i915_request_mark_complete(rq); … | spin_unlock_irq(&rq->lock);
has been avoided because an interrupt here could change something or if this is just an optimisation.
Just avoiding the back-to-back enable/disable.
as I assumed. Is the patch okay?
-Chris
Sebastian