Re: [PATCH] drm: atmel-hlcdc: Atomic mode-setting conversion

On Thu, 5 Feb 2015 14:08:32 +0100 Daniel Vetter daniel@ffwll.ch wrote:

On Wed, Feb 04, 2015 at 09:20:51PM +0100, Boris Brezillon wrote:

...

Convert the HLCDC driver to atomic mode-setting.

Signed-off-by: Boris Brezillon boris.brezillon@free-electrons.com

Just a quick comment: dpms isn't yet converted over, and from experience with tegra/msm that probably will yield some surprises. Since only with dpms will it be obvious how strict the added requirements from the atomic helpers are ;-)

Yes, I noticed I was not using the appropriate dpms helper in the connector funcs just after sending this patch.

Would this patch [1] address what you're talking about, or am I still missing something ?

Thanks,

Boris

[1]http://code.bulix.org/l70xf4-87827