Re: [PATCH v2 02/12] mm: Introduce a function to check for virtualization protection features

On 8/14/21 1:32 PM, Borislav Petkov wrote:

On Fri, Aug 13, 2021 at 11:59:21AM -0500, Tom Lendacky wrote:

...

diff --git a/include/linux/protected_guest.h b/include/linux/protected_guest.h new file mode 100644 index 000000000000..43d4dde94793 --- /dev/null +++ b/include/linux/protected_guest.h @@ -0,0 +1,35 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/*

• • Protected Guest (and Host) Capability checks
• • Copyright (C) 2021 Advanced Micro Devices, Inc.
• • Author: Tom Lendacky thomas.lendacky@amd.com
• */

+#ifndef _PROTECTED_GUEST_H +#define _PROTECTED_GUEST_H

+#ifndef __ASSEMBLY__

  ^^^^^^^^^^^^^

Do you really need that guard? It builds fine without it too. Or something coming later does need it...?

No, I probably did it out of habit. I can remove it in the next version.

Thanks, Tom