Re: [PATCH 2/5] drm/format-helper: Fix XRGB888 to monochrome conversion

On Tue, Mar 15, 2022 at 01:18:00PM +0100, Javier Martinez Canillas wrote:

On 3/15/22 12:07, Geert Uytterhoeven wrote:

...

• for (i = 0; i < bits; i++, pixels--) {
  

I think is worth to add a comment here explaining that the pixel is set to 1 for brightness > 127 and to 0 for brightness < 128. Or as kernel-doc for this helper function.

...

• 	if (*src++ & BIT(7))
  

Pekka also mentioned that if (*src++ > 127) would make this easier to read.

= 128 ?

...

• 		byte |= BIT(i);
  

  } *dst++ = byte; }