On Fri, Jul 03, 2020 at 12:44:48PM +0200, megous hlavni wrote:
Hello Sam,
On Fri, Jul 03, 2020 at 07:11:55AM +0200, Sam Ravnborg wrote:
Hi Ondrej.
My bot found errors running 'make dt_binding_check' on your patch:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property
Paths look bogus ^^^^
It should be .../rocktech,jh057n00900.yaml: ...
The example in nwl-dsi.yaml contains: compatible = "rocktech,jh057n00900";
So the example is checked against your updated binding. And the binding check fails because the example is no longer valid.
Ah, now I understand.
This needs to be fixed as we do not wat to introduce new errors. Either the example or the binding needs the fix.
I think we can unrequire the supplies, but reset is needed really.
Hmm, that's probably wrong kind of thinking. Panel has the supplies, and obviously requires them, so the dts must describe them somehow, even if they are the fixed supplies. So I'll not unrequire them.
The panel only has one port, so there should be no address/size-cells in the example, and port@0 should be just port to match existing binding. If it had multiple ports, port@0 would have to be inside ports { } node anyway, according to the existing binding. Then add reset-gpios to the example...
And that should fix it.
I'll prepare the patch shortly.
regards, o.
Sam
regards, o.
See https://patchwork.ozlabs.org/patch/1320690
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
Please check and re-submit.