Hi Stephen,
I love your patch! Yet something to improve:
[auto build test ERROR on e4e737bb5c170df6135a127739a9e6148ee3da82]
url: https://github.com/0day-ci/linux/commits/Stephen-Boyd/component-Make-into-an... base: e4e737bb5c170df6135a127739a9e6148ee3da82 config: arm-allyesconfig (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/86c48d693131c045853b0370583c7bcb8ac4... git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Stephen-Boyd/component-Make-into-an-aggregate-bus/20211026-080422 git checkout 86c48d693131c045853b0370583c7bcb8ac46308 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot lkp@intel.com
All errors (new ones prefixed by >>):
drivers/gpu/drm/omapdrm/dss/dss.c:1345:19: error: initialization of 'void (*)(struct aggregate_device *)' from incompatible pointer type 'void (*)(struct device *)' [-Werror=incompatible-pointer-types]
1345 | .remove = dss_unbind, | ^~~~~~~~~~ drivers/gpu/drm/omapdrm/dss/dss.c:1345:19: note: (near initialization for 'dss_aggregate_driver.remove') cc1: all warnings being treated as errors
vim +1345 drivers/gpu/drm/omapdrm/dss/dss.c
1342 1343 static struct aggregate_driver dss_aggregate_driver = { 1344 .probe = dss_bind,
1345 .remove = dss_unbind,
1346 .driver = { 1347 .name = "dss_drm", 1348 .owner = THIS_MODULE, 1349 }, 1350 }; 1351
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org