Re: [PATCH v2 1/2] drm/amdgpu: fix bug when amdkfd destroys hqd

On Wed, Jul 29, 2015 at 4:57 AM, Oded Gabbay oded.gabbay@gmail.com wrote:

The wrong define was used to check if the hqd is still active

v2: Don't use SHIFT as the MASK is already shifted

Signed-off-by: Oded Gabbay oded.gabbay@gmail.com

Reviewed-by: Alex Deucher alexander.deucher@amd.com

---

drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c index 2daad33..dd2037b 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v7.c @@ -450,7 +450,7 @@ static int kgd_hqd_destroy(struct kgd_dev *kgd, uint32_t reset_type,

    while (true) {
            temp = RREG32(mmCP_HQD_ACTIVE);

•           if (temp & CP_HQD_ACTIVE__ACTIVE__SHIFT)
  

•           if (temp & CP_HQD_ACTIVE__ACTIVE_MASK)
                    break;
            if (timeout == 0) {
                    pr_err("kfd: cp queue preemption time out (%dms)\n",
  

-- 2.4.3