On Wed, Feb 12, 2014 at 8:37 PM, Michel Dänzer michel@daenzer.net wrote:
On Mit, 2014-02-12 at 13:28 -0500, Alex Deucher wrote:
Some hardware may not support standard 64x64 cursors. Add a drm cap to query the cursor size from the kernel. Some examples include radeon CIK parts (128x128 cursors) and armada (32x64 or 64x32). This allows things like device specific ddxes to remove asics specific logic and also allows xf86-video-modesetting to work properly with hw cursors on this hardware. Default to 64 if the driver doesn't specify a size.
The patches look good, but what's your plan for dealing with other KMS apps such as Wayland compositors (weston is also affected by this, I assume so is gnome-shell, maybe more)? I was thinking it might be good to have a backup plan in the kernel, e.g. copying from the BO passed in by userspace to a different BO if the former doesn't match the hardware size.
I think the easiest fix would be for them to fix up support similarly to what I did for xf86-video-modesetting so they are ready to go once distros start enabling them by default. Adjusting the image on the fly in the kernel seems a like pain.
Alex
-- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer