Hi Alexey, On Sun, Jul 25, 2021 at 05:03:37PM +0300, Alexey Minnekhanov wrote:
The Samsung S6E3FA2 AMOLED cmd LCD panel is used on Samsung Galaxy S5 (klte) phone.
Signed-off-by: Alexey Minnekhanov alexeymin@postmarketos.org
.../display/panel/samsung,s6e3fa2.yaml | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,s6e3fa2.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e3fa2.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e3fa2.yaml new file mode 100644 index 000000000000..d5628ae81141 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e3fa2.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/samsung,s6e3fa2.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Samsung s6e3fa2 AMOLED CMD LCD DSI panel
+maintainers:
- Alexey Minnekhanov alexeymin@postmarketos.org
+allOf:
- $ref: panel-common.yaml#
+properties:
- compatible:
- const: samsung,s6e3fa2
- reg: true
- reset-gpios: true
- port: true
- iovdd-supply:
- description: IOVDD regulator
- vddr-supply:
- description: VDDR regulator
+required:
- compatible
reg?
- reset-gpios
- iovdd-supply
- vddr-supply
+unevaluatedProperties: false
As I do not see the DT node pull in additional preperties from another binding the more strict: additionalProperties: false seems to be the right choise here. In this way the DT check will catch if thre are properties specified that are not listed by the binding.
With this fixed: Reviewed-by: Sam Ravnborg sam@ravnborg.org
Sam
+examples:
- |
- /* from Samsung Galaxy S5 klte */
- #include <dt-bindings/gpio/gpio.h>
- dsi {
#address-cells = <1>;#size-cells = <0>;panel@0 {compatible = "samsung,s6e3fa2";reg = <0>;reset-gpios = <&pma8084_gpios 17 GPIO_ACTIVE_LOW>;iovdd-supply = <&pma8084_lvs4>;vddr-supply = <&vreg_panel>;port {panel_in: endpoint {remote-endpoint = <&dsi0_out>;};};};- };
+...
2.31.1