On Wed, Aug 4, 2021 at 8:59 PM Karol Herbst kherbst@redhat.com wrote:
On Wed, Aug 4, 2021 at 4:43 PM Karol Herbst kherbst@redhat.com wrote:
On Wed, Aug 4, 2021 at 4:19 PM Arnd Bergmann arnd@kernel.org wrote:
On Wed, Aug 4, 2021 at 4:10 PM Karol Herbst kherbst@redhat.com wrote:
playing around a little bit with this, I think the original "select BACKLIGHT_CLASS_DEVICE" is fine. Atm we kind of have this weird mix of drivers selecting and others depending on it. We could of course convert everything over to depend, and break those cycling dependency issues with this.
Anyway this change on top of my initial patch is enough to make Kconfig happy and has the advantage of not having to mess with the deps of nouveau too much.
Looks good to me. We'd probably want to make the BACKLIGHT_CLASS_DEVICE option itself 'default FB || DRM' though, to ensure that defconfigs keep working.
okay cool. Will send out a proper updated patch series soonish.
mhh, actually that breaks drivers selecting FB_BACKLIGHT as now BACKLIGHT_CLASS_DEVICE might be disabled :(
Are you sure? It should already be the case that any driver that selects FB_BACKLIGHT either 'depends on BACKLIGHT_CLASS_DEVICE' or 'select BACKLIGHT_CLASS_DEVICE'.
If you change all the 'select BACKLIGHT_CLASS_DEVICE' to 'depends on', I don't see a problem with doing 'select FB_BACKLIGHT' from those.
I have applied your patch to my randconfig tree and built a few dozen kernels, don't see any regressions so far, but will let it run over night.
Arnd