Re: [Intel-gfx] [PATCH 2/3] drm/i915/guc: downgrade some DRM_ERROR() messages to DRM_WARN()

On Tue, Jul 12, 2016 at 10:20:43AM +0100, Tvrtko Ursulin wrote:

On 11/07/16 19:01, Dave Gordon wrote:

...

@@ -553,8 +551,8 @@ static int guc_ring_doorbell(struct i915_guc_client *gc) if (db_ret.db_status == GUC_DOORBELL_DISABLED) break;

• DRM_ERROR("Cookie mismatch. Expected %d, returned %d\n",
  

• 	  db_cmp.cookie, db_ret.cookie);
  

• DRM_WARN("Cookie mismatch. Expected %d, found %d\n",
  

• 	 db_cmp.cookie, db_ret.cookie);
  

This one is interesting, error is propagated out a bit but then ignored in actual command submission.

If the above message means command will not be submitted error is probably more appropriate. Or perhaps we cannot tell if the command was submitted or not in this case?

It's insignificant. An actual error would result in a GPU hang, and without being recorded in the error state any message here is useless. -Chris