Re: [PATCH 3/3] drm: rcar-du: Convert rcar_du_encoders_init_one() return value to 0/<0

Hi Geert,

On Tuesday 26 May 2015 21:24:03 Geert Uytterhoeven wrote:

On Tue, May 26, 2015 at 5:01 PM, Laurent Pinchart wrote:

...

--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c @@ -640,14 +640,14 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu, of_node_put(connector);

    if (!ret)

•           return 1;
  

•           return 0;
  
    if (ret != -EPROBE_DEFER)
            dev_warn(rcdu->dev,
                     "failed to initialize encoder %s (%d),
                     skipping\n",
                     encoder->full_name, ret);
  
  

•   return 0;
  

•   return ret;
  

}

Perhaps just

    if (ret && ret != -EPROBE_DEFER)
            dev_warn(...);

   return ret;

?

Good point. I'll fix that.