Hi
Am 14.07.21 um 10:39 schrieb Yang Yingliang:
Fix the missing pci_disable_device() before return from bochs_pci_probe() in the error handling case.
It's maybe better to replace pci_enable_device() with pcim_enable_device(), [1] so that the release happens automatically. Does this work?
Best regards Thomas
https://elixir.bootlin.com/linux/v5.13.1/source/drivers/pci/pci.c#L2042
Reported-by: Hulk Robot hulkci@huawei.com Signed-off-by: Yang Yingliang yangyingliang@huawei.com
drivers/gpu/drm/tiny/bochs.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c index a2cfecfa8556..74832b9d3eae 100644 --- a/drivers/gpu/drm/tiny/bochs.c +++ b/drivers/gpu/drm/tiny/bochs.c @@ -666,6 +666,7 @@ static int bochs_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent return ret;
err_free_dev:
- pci_disable_device(pdev); drm_dev_put(dev); return ret; }