Hi Daniel,
Thanks for the patch.
On Wednesday 31 October 2012 10:11:49 Daniel Vetter wrote:
Again only minimal changes to make kerneldoc no longer shout. Plus a little introduction in the form of a inline DOC: section to quickly explain what this is all about.
Signed-off-by: Daniel Vetter daniel.vetter@ffwll.ch
With the error below fixed,
Acked-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Documentation/DocBook/drm.tmpl | 5 +++++ drivers/gpu/drm/drm_fb_helper.c | 19 ++++++++++++++----- 2 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl index 43e706e..15729eb 100644 --- a/Documentation/DocBook/drm.tmpl +++ b/Documentation/DocBook/drm.tmpl @@ -2110,6 +2110,11 @@ void intel_crt_init(struct drm_device *dev) <title>Modeset Helper Functions Reference</title> !Edrivers/gpu/drm/drm_crtc_helper.c </sect2>
<sect2>
<title>fbdev Helper Functions Reference</title>+!Pdrivers/gpu/drm/drm_fb_helper.c fbdev helpers +!Edrivers/gpu/drm/drm_fb_helper.c
</sect2> </sect1>
<!-- Internals: vertical blanking -->
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 4d58d7e..b6e9893 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -41,7 +41,14 @@ MODULE_AUTHOR("David Airlie, Jesse Barnes"); MODULE_DESCRIPTION("DRM KMS helper"); MODULE_LICENSE("GPL and additional rights");
-static LIST_HEAD(kernel_fb_helper_list); +/**
- DOC: fbdev helpers
- The fb helper functions are useful to provide an fbdev on top of a drm
- kernel mode setting driver. They can be used mostly independantely from
- the crtc helper functions used by many drivers to implement the kernel
- mode setting interfaces. static LIST_HEAD(kernel_fb_helper_list).
- */
Unless you plan to modify the kerneldoc infrastructure to extract code from the comments and feed it to the compiler, I'm pretty sure this will break compilation ;-)
/* simple single crtc case helper function */ int drm_fb_helper_single_add_all_connectors(struct drm_fb_helper *fb_helper) @@ -1291,12 +1298,14 @@ static void drm_setup_crtcs(struct drm_fb_helper *fb_helper)
/**
- drm_helper_initial_config - setup a sane initial connector configuration
- @dev: DRM device
- @fb_helper: fb_helper device struct
- @bpp_sel: bpp value to use for the framebuffer configuration
- LOCKING:
- Called at init time, must take mode config lock.
- Called at init time by the driver to set up the @fb_helper initial
- configuration, must take mode config lock.
- Scan the CRTCs and connectors and try to put together an initial setup.
- Scans the CRTCs and connectors and tries to put together an initial
- setup. At the moment, this is a cloned configuration across all heads
- with a new framebuffer object as the backing store.
@@ -1330,7 +1339,7 @@ EXPORT_SYMBOL(drm_fb_helper_initial_config);
/**
- drm_fb_helper_hotplug_event - respond to a hotplug notification by
probing all the outputs attached to thefb.
probing all the outputs attached to the fb- @fb_helper: the drm_fb_helper
- LOCKING: