On Tue, Dec 22, 2020 at 09:00:43AM +0000, Simon Ser wrote:
On Tuesday, December 22nd, 2020 at 9:55 AM, Daniel Vetter daniel@ffwll.ch wrote:
On Fri, Dec 11, 2020 at 05:11:13PM +0100, Daniel Vetter wrote:
I tried to fix this for real, but it's very sprawling and lots of drivers get this mildly wrong one way or the other.
Signed-off-by: Daniel Vetter daniel.vetter@intel.com Cc: Maarten Lankhorst maarten.lankhorst@linux.intel.com Cc: Maxime Ripard mripard@kernel.org Cc: Thomas Zimmermann tzimmermann@suse.de Cc: David Airlie airlied@linux.ie Cc: Daniel Vetter daniel@ffwll.ch
Anyone feeling like an ack on this one?
From my limited understanding of fbdev, this FIXME sounds correct to me.
Acked-by: Simon Ser contact@emersion.fr
Thanks for taking a look, patch pushed to drm-misc-next. -Daniel
drivers/gpu/drm/drm_fb_helper.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index 596255edf023..27deed4af015 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -2494,6 +2494,11 @@ void drm_fbdev_generic_setup(struct drm_device *dev, return; }
- /*
* FIXME: This mixes up depth with bpp, which results in a glorious* mess, resulting in some drivers picking wrong fbdev defaults and* others wrong preferred_depth defaults.*/-- 2.29.2