Hi Laurent.
My meta-schemas foo is very limited, but I noticed a few things. Hopefully Rob finds time soon to review.
Sam
On Sun, Aug 11, 2019 at 02:10:42AM +0300, Laurent Pinchart wrote:
The NEC NL8048HL11 is a 10.4cm WVGA (800x480) panel with a 24-bit RGB parallel data interface and an SPI control interface.
Signed-off-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
Changes since v1:
- Convert to YAML
.../display/panel/nec,nl8048hl11.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml new file mode 100644 index 000000000000..cc3d40975828 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/nec,nl8048hl11.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/nec,nl8048hl11.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: NEC NL8048HL11 4.1" WVGA TFT LCD panel
+description:
- The NEC NL8048HL11 is a 4.1" WVGA TFT LCD panel with a 24-bit RGB parallel
- data interface and an SPI control interface.
+maintainers:
- Laurent Pinchart laurent.pinchart@ideasonboard.com
+allOf:
- $ref: panel-common.yaml#
I *think* we are missing a reference to spi-controller.yaml here.
+properties:
- compatible:
- const: nec,nl8048hl11
- label: true
- reset-gpios: true
- port: true
+required:
- compatible
- reset-gpios
- port
+additionalProperties: false
+examples:
- |
- lcd_panel: panel {
compatible = "nec,nl8048hl11";spi-max-frequency = <10000000>;
Not sure, but should there be a reg property here for spi too?
reset-gpios = <&gpio7 7 GPIO_ACTIVE_LOW>;port {lcd_in: endpoint {remote-endpoint = <&dpi_out>;};};- };
+...
Regards,
Laurent Pinchart