Hi Thierry,
On Fri, Jun 5, 2015 at 1:20 PM, Thierry Reding thierry.reding@gmail.com wrote:
On Tue, May 05, 2015 at 06:32:17PM +0200, Geert Uytterhoeven wrote:
If GPIOLIB=n and asm-generic/gpio.h is not used:
drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_pre_enable’: drivers/gpu/drm/bridge/ptn3460.c:135: error: implicit declaration of function ‘gpiod_set_value’ drivers/gpu/drm/bridge/ptn3460.c: In function ‘ptn3460_probe’: drivers/gpu/drm/bridge/ptn3460.c:333: error: implicit declaration of function ‘devm_gpiod_get’ drivers/gpu/drm/bridge/ptn3460.c:333: warning: assignment makes pointer from integer without a cast drivers/gpu/drm/bridge/ptn3460.c:340: error: implicit declaration of function ‘gpiod_direction_output’ drivers/gpu/drm/bridge/ptn3460.c:346: warning: assignment makes pointer from integer without a castAdd the missing #include <linux/gpio/consumer.h> to fix this.
As the resulting driver won't work with GPIOLIB=n anyway, make DRM_PTN3460 depend on GPIOLIB || COMPILE_TEST.
Signed-off-by: Geert Uytterhoeven geert@linux-m68k.org Cc: David Airlie airlied@linux.ie Cc: dri-devel@lists.freedesktop.org
drivers/gpu/drm/bridge/Kconfig | 4 ++-- drivers/gpu/drm/bridge/ptn3460.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-)
Applied, thanks. Note that I dropped the part about adding the GPIOLIB dependency because that had been attempted previously to fix this, but it causes recursive dependencies on PowerPC (ppc64_defconfig). I don't know of a way to untangle those (I tried and failed miserably), so I think adding the include is really as good as it'll get.
Thanks!
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds