On Thu, Jan 31, 2013 at 1:55 AM, Su, Xuemin xuemin.su@intel.com wrote:
-----Original Message----- From: Jani Nikula [mailto:jani.nikula@linux.intel.com] Sent: Thursday, January 24, 2013 5:05 PM To: Su, Xuemin Cc: airlied@linux.ie; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org; yanmin_zhang@linux.intel.com; He, Bo Subject: Re: [PATCH V3] drm_crtc: check if fb_create return NULL
Ah, sorry, never mind, I missed Daniel's comment. The benefit of the BUG_ON() is making it clear what's expected of the drivers.
Reviewed-by: Jani Nikula jani.nikula@intel.com
Do you think this patch is still needed? Currently I fix a buggy function radeon_user_framebuffer_create() which returns NULL and patch is added to 3.7-stable tree. Do you think it's also needed to do something in drm_mode_addfb()?
Imo it's still useful, just to document the assumptions of the interface. Dave? -Daniel