Re: [PATCH] drm: shmob_drm: Check clk_prepare_enable() return value

On Mon, Dec 02, 2013 at 01:52:20AM +0100, Laurent Pinchart wrote: [...]

diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c

[...]

@@ -170,7 +178,9 @@ static void shmob_drm_crtc_start(struct shmob_drm_crtc *scrtc) return;

/* Enable clocks before accessing the hardware. */

• shmob_drm_clk_on(sdev);

• ret = shmob_drm_clk_on(sdev);
• if (ret < 0)

• return;
  

Perhaps this should be printing an error or using WARN_ON()? Otherwise it might be very difficult to diagnose what's going wrong.

Thierry