Re: [PATCH RFC] drm/i2c: tda998x: dead-code or unhandled error condition ?

On Wed, 10 Jun 2015 14:58:48 +0200 Nicholas Mc Guire hofrat@osadl.org wrote:

event API conformance testing with coccinelle spatches are being used to locate API usage inconsistencies this triggert with: ./drivers/gpu/drm/i2c/tda998x_drv.c:1062 incorrect check for negative return

The return of wait_event_timeout is always >= 0, thus the negative check was effectively being ignoring - as the timeout will be checked a few lines below the error condition being checked here seems to be wrong or this is simply dead code which would be my guess as the timeout condition check covers the wait-queue related failure condition.

Signed-off-by: Nicholas Mc Guire hofrat@osadl.org

Acked-by: Jean-Francois Moine moinejf@free.fr