Re: [patch] drm/i915: checking IS_ERR() instead of NULL

On Thu, Apr 30, 2015 at 05:47:13PM +0300, Dan Carpenter wrote:

On Thu, Apr 30, 2015 at 03:43:02PM +0100, Chris Wilson wrote:

...

On Thu, Apr 30, 2015 at 05:30:50PM +0300, Dan Carpenter wrote:

...

We switched from calling i915_gem_alloc_context_obj() to calling i915_gem_alloc_object() so the error handling needs to be updated to check for NULL instead of IS_ERR().

I had a patch to change i915_gem_alloc_object() to report the correct error rather than NULL - which can come in surprisingly handy at times...

That also works, of course. Send it. :)

Doesn't seem to have shown up yet, I applied your patch meanwhile.

Thanks, Daniel