4 Dec
2012
4 Dec
'12
6:17 a.m.
On 03.12.2012 23:03, Thierry Reding wrote:
What's really difficult to follow is if an ops structure is accessed via some global macro. It also breaks encapsulation because you have a global ops structure. That may even work fine for now, but it will break once you have more than a single host1x in a system. I know this will never happen, but all of a sudden it happens anyway and the code breaks. Doing this right isn't very hard and it will lead to a better design and is less likely to break at some point.
I agree that the chip ops access goes through too much indirection and macro magic (which I already declared I hate), so we're going to design something simpler.
Terje