On Wed, Apr 29, 2020 at 07:51:07PM +0200, Sam Ravnborg wrote:
On Wed, Apr 29, 2020 at 04:32:22PM +0200, Thomas Zimmermann wrote:
The HW cursor of Matrox G200 cards only supports a 16-color palette format. Univeral planes require at least ARGB or a similar component- based format. Converting a cursor image from ARGB to 16 colors does not produce pleasent-looking results in general, so remove the HW cursor.
What impact does this have in useability? Does the cursor behaviour stay the same or?
xorg/wayland switch to software cursor then. Shouldn't be a big difference. If you wanna check how userspace behaves without g200 hardware you can try qemu. stdvga (bochs-drm.ko) has no hardware cursor, virtio-vga (virtio-gpu.ko) has a hardware cursor.
The patch looks fine, but it seems a bit gross ditching curcor support. But maybe it is the right choice, I dunno.
cirrus driver does the same. The hardware has cursor support, but not rgba, and it is not used.
take care, Gerd