Re: [PATCH RFC v2 5/5] ARM: dts: qcom: msm8974-hammerhead: add support for external display

Quoting Brian Masney (2019-10-06 18:45:09)

diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts index b607c9ff9e12..380a805cd1f0 100644 --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts @@ -371,6 +401,40 @@ function = "gpio"; }; };

•           hdmi_pin: hdmi {
  

•                   cec {
  

•                           pins = "gpio31";
  

•                           function = "hdmi_cec";
  

•                   };
  

•                   ddc {
  

•                           pins = "gpio32", "gpio33";
  

•                           function = "hdmi_ddc";
  

•                   };
  

•                   hpd {
  

•                           pins = "gpio34";
  

•                           function = "hdmi_hpd";
  

•                   };
  

•           };
  

•           anx_msm_pin: anx {
  

•                   irq {
  

•                           pins = "gpio28";
  

•                           function = "gpio";
  

Is function = "gpio" necessary anymore? I thought we would turn gpios into gpio function when it's requested as a gpio by some consumer.

•                           drive-strength = <8>;
  

•                           bias-pull-up;
  

•                           input-enable;
  

•                   };
  

•                   reset {
  

•                           pins = "gpio68";
  

•                           function = "gpio";
  

•                           drive-strength = <8>;
  

•                           bias-pull-up;
  

•                   };
  

•           };
    };
  
    vibrator@fd8c3450 {