On Fri, Oct 09, 2015 at 06:16:25PM -0400, Dan Williams wrote:
i915 expects the OpRegion to be cached (i.e. not __iomem), so explicitly map it with memremap rather than the implied cache setting of acpi_os_ioremap().
Cc: Daniel Vetter daniel.vetter@intel.com Cc: Jani Nikula jani.nikula@linux.intel.com Cc: intel-gfx@lists.freedesktop.org Cc: David Airlie airlied@linux.ie Cc: dri-devel@lists.freedesktop.org Signed-off-by: Dan Williams dan.j.williams@intel.com
Assuming you've run sparse over this to make sure you've caught them all, and with the nit below addressed this is
Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch
Feel free to pull v2 into whatever tree you think it's suitable for (but you can also resend and I'll pick it up).
diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index e2ab3f6ed022..c8444d5f549f 100644 --- a/drivers/gpu/drm/i915/intel_panel.c +++ b/drivers/gpu/drm/i915/intel_panel.c @@ -387,7 +387,7 @@ intel_panel_detect(struct drm_device *dev)
/* Assume that the BIOS does not lie through the OpRegion... */ if (!i915.panel_ignore_lid && dev_priv->opregion.lid_state) {
return ioread32(dev_priv->opregion.lid_state) & 0x1 ?
return *(dev_priv->opregion.lid_state) & 0x1 ?
() are redundant now here. -Daniel
connector_status_connected : connector_status_disconnected;}
Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx