On Sun, Jun 28, 2020 at 11:02:53AM +0300, Laurent Pinchart wrote:
Hi Sam,
We should also clean up all the DRM_BUS_FLAG_* one day. No need for the deprecated values, so a few files needs an update. And we could document what flags makes sense for LVDS etc.
Where would you add that documentation ? The hardest part is to find a place that will be noticed by developers :-)
I will try to extend drm_bus_flags documentation in drm_connector.h And then add a few comments in panel-simple as well.
Sam
I've just submitted a patch that adds a WARN_ON to catch similar issues in the panel-simple driver. It's not ideal as we really shouldn't have such code in the kernel, this is something that should be caught as part of the integration process.
On the TODO list...
The rest looks good, except the Samsung panel for which I haven't been able to locate a datasheet.
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
-- Regards,
Laurent Pinchart