This crash was already here before the conversion, but qxl never leaked hard enough to hit this.
Signed-off-by: Maarten Lankhorst maarten.lankhorst@canonical.com --- The crash is probably only going to happen in extreme memory stress when the system's already fucked, but hey still a bug. :-)
drivers/gpu/drm/qxl/qxl_release.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_release.c b/drivers/gpu/drm/qxl/qxl_release.c index 29ab4ec44c40..a6e19c83143e 100644 --- a/drivers/gpu/drm/qxl/qxl_release.c +++ b/drivers/gpu/drm/qxl/qxl_release.c @@ -440,7 +440,7 @@ void qxl_release_fence_buffer_objects(struct qxl_release *release)
/* if only one object on the release its the release itself since these objects are pinned no need to reserve */ - if (list_is_singular(&release->bos)) + if (list_is_singular(&release->bos) || list_empty(&release->bos)) return;
bo = list_first_entry(&release->bos, struct ttm_validate_buffer, head)->bo;