Re: [PATCH v3 3/4] drm/bridge: Add devm_drm_bridge_add()

Hi,

On Tue, May 10, 2022 at 5:22 PM Dmitry Baryshkov dmitry.baryshkov@linaro.org wrote:

On Tue, 10 May 2022 at 22:30, Douglas Anderson dianders@chromium.org wrote:

...

This adds a devm managed version of drm_bridge_add(). Like other "devm" function listed in drm_bridge.h, this function takes an explicit "dev" to use for the lifetime management. A few notes:

• In general we have a "struct device" for bridges that makes a good candidate for where the lifetime matches exactly what we want.
• The "bridge->dev->dev" device appears to be the encoder device. That's not the right device to use for lifetime management.

Suggested-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org Signed-off-by: Douglas Anderson dianders@chromium.org

Reviewed-by: Dmitry Baryshkov dmitry.baryshkov@linaro.org

Thanks for the review! For now I'll hold off on landing this until sometime has time to review the other patches in the series. While not technically required, it seems weird to add the devm function without any callers.

-Doug