Hi Simon,
On Fri, Oct 15, 2021 at 04:33:41PM +0000, Simon Ser wrote:
This function sends a hotplug uevent with a CONNECTOR property.
A little late feedback.
Sam
Signed-off-by: Simon Ser contact@emersion.fr
drivers/gpu/drm/drm_sysfs.c | 25 +++++++++++++++++++++++++ include/drm/drm_sysfs.h | 1 + 2 files changed, 26 insertions(+)
diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 76ff6ec3421b..430e00b16eec 100644 --- a/drivers/gpu/drm/drm_sysfs.c +++ b/drivers/gpu/drm/drm_sysfs.c @@ -409,6 +409,31 @@ void drm_sysfs_hotplug_event(struct drm_device *dev) } EXPORT_SYMBOL(drm_sysfs_hotplug_event);
+/**
- drm_sysfs_connector_hotplug_event - generate a DRM uevent for any connector
- change
- @connector: connector which has changed
- Send a uevent for the DRM connector specified by @connector. This will send
- a uevent with the properties HOTPLUG=1 and CONNECTOR.
- */
+void drm_sysfs_connector_hotplug_event(struct drm_connector *connector) +{
- struct drm_device *dev = connector->dev;
- char hotplug_str[] = "HOTPLUG=1", conn_id[21];
- char *envp[] = { hotplug_str, conn_id, NULL };
- snprintf(conn_id, sizeof(conn_id),
"CONNECTOR=%u", connector->base.id);
We have add_uevent_var() that seems a better choice than handrolling snprintf here.
Sam
- drm_dbg_kms(connector->dev,
"[CONNECTOR:%d:%s] generating connector hotplug event\n",connector->base.id, connector->name);- kobject_uevent_env(&dev->primary->kdev->kobj, KOBJ_CHANGE, envp);
+} +EXPORT_SYMBOL(drm_sysfs_connector_hotplug_event);
/**
- drm_sysfs_connector_status_event - generate a DRM uevent for connector
- property status change
diff --git a/include/drm/drm_sysfs.h b/include/drm/drm_sysfs.h index d454ef617b2c..6273cac44e47 100644 --- a/include/drm/drm_sysfs.h +++ b/include/drm/drm_sysfs.h @@ -11,6 +11,7 @@ int drm_class_device_register(struct device *dev); void drm_class_device_unregister(struct device *dev);
void drm_sysfs_hotplug_event(struct drm_device *dev); +void drm_sysfs_connector_hotplug_event(struct drm_connector *connector); void drm_sysfs_connector_status_event(struct drm_connector *connector, struct drm_property *property);
#endif
2.33.1