On Monday, April 23, 2018 02:47:28 PM Bartlomiej Zolnierkiewicz wrote:
On Friday, April 20, 2018 01:42:51 PM Mauro Carvalho Chehab wrote:
Add stubs for omapfb_dss.h, in the case it is included by some driver when CONFIG_FB_OMAP2 is not defined, with can happen on ARM when DRM_OMAP is not 'n'.
That allows building such driver(s) with COMPILE_TEST.
Signed-off-by: Mauro Carvalho Chehab mchehab@s-opensource.com
This patch should be dropped (together with patch #6/7) as it was superseded by a better solution suggested by Laurent:
https://patchwork.kernel.org/patch/10325193/
ACK-ed by Tomi:
https://www.spinics.net/lists/dri-devel/msg171918.html
and already merged by you (commit 7378f1149884 "media: omap2: omapfb: allow building it with COMPILE_TEST")..
Hmm, I see now while this patch is still included:
menuconfig FB_OMAP2 tristate "OMAP2+ frame buffer support" depends on FB depends on DRM_OMAP = n
Ideally we should be able to build both drivers in the same kernel (especially as modules).
I was hoping that it could be fixed easily but then I discovered the root source of the problem:
drivers/gpu/drm/omapdrm/dss/display.o: In function `omapdss_unregister_display': display.c:(.text+0x2c): multiple definition of `omapdss_unregister_display' drivers/video/fbdev/omap2/omapfb/dss/display.o:display.c:(.text+0x198): first defined here ...
I need some more time to think about this..
Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics