On Wed, Nov 10, 2010 at 6:04 PM, Andy Lutomirski luto@mit.edu wrote:
Nouveau takes down my system quite reliably when any hotplug event occurs. The bug happens because the IRQ handler didn't acknowledge the hotplug state until the bottom half, so the card generated a new interrupt immediately, starving the bottom half and permanently starving that CPU (and hence the bottom half).
Even with this fix, a lot of the IRQ code looks rather broken.
This is tested on 2.6.36 (and makes the system stable for me), but it also applies cleanly to 2.6.37 (untested, but surely also necessary). Fedora 14's 2.6.35 kernels seem to have to same problem for me, so I suspect that 2.6.35 needs this fix as well. (All of my tests are on an NV50 card.)
Changes from v1: - Ignore unrequested hotplug bits (I accidentally removed that part). - Support newer hardware (untested -- Ben, can you check this?)
Just a quick ping: is this making its way to Linus (and stable)? I've been running it for five days through (literally, due to monitor bugs) thousands of plug/unplug cycles with no ill effects.
(Can we *please* get rid of, or at least ratelimit, the plugged/unplugged printk? It's taking over my logs, and I'm almost certain that it's not a driver bug.)
--Andy