Re: [PATCH v2 1/2] Documentation: bindings: Add ANX7688 HDMI to DP bridge binding

On Thu, Feb 13, 2020 at 03:54:15PM +0100, Enric Balletbo i Serra wrote:

From: Nicolas Boichat drinkcat@chromium.org

'dt-bindings: ....' for the subject please.

Add documentation for DT properties supported by anx7688 HDMI-DP converter.

Signed-off-by: Nicolas Boichat drinkcat@chromium.org Signed-off-by: Hsin-Yi Wang hsinyi@chromium.org Signed-off-by: Enric Balletbo i Serra enric.balletbo@collabora.com

---

Changes in v2:

• Improve a bit the descriptions using the info from the datasheet.
• Convert binding to yaml.
• Use dual licensing.

.../bindings/display/bridge/anx7688.yaml | 79 +++++++++++++++++++

Use the full compatible string: analogix,anx7688.yaml

1 file changed, 79 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/anx7688.yaml

diff --git a/Documentation/devicetree/bindings/display/bridge/anx7688.yaml b/Documentation/devicetree/bindings/display/bridge/anx7688.yaml new file mode 100644 index 000000000000..c1b4b5191d44 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/anx7688.yaml @@ -0,0 +1,79 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/anx7688.yaml#

Don't forget to update this too.

+$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Analogix ANX7688 HDMI to USB Type-C Bridge (Port Controller with MUX)

+maintainers:

• • Nicolas Boichat drinkcat@chromium.org
• • Enric Balletbo i Serra enric.balletbo@collabora.com

+description: |

• The ANX7688 is a single-chip mobile transmitter to support 4K 60 frames per
• second (4096x2160p60) or FHD 120 frames per second (1920x1080p120) video
• resolution from a smartphone or tablet with full function USB-C.
• This binding only describes the HDMI to DP display bridge.

+properties:

• compatible:
• const: analogix,anx7688
• reg:
• maxItems: 1
• description: I2C address of the device

That's every reg, you can drop 'description'.

• ports:
• type: object
• properties:

•  port@0:
  

•    type: object
  

•    description: |
  

•      Video port for HDMI input
  

•  port@1:
  

•    type: object
  

•    description: |
  

•      Video port for DP output
  

• required:

•  - port@0
  

IMO, port@1 should be required too. If not a fixed panel, then it should have a connector node.

+required:

• • compatible
• • reg
• • ports

+examples:

• • |
• i2c0 {

•    #address-cells = <1>;
  

•    #size-cells = <0>;
  

•    anx7688: dp-bridge@2c {
  

•        compatible = "analogix,anx7688";
  

•        reg = <0x2c>;
  

•        ports {
  

•            #address-cells = <1>;
  

•            #size-cells = <0>;
  

•            port@0 {
  

•                reg = <0>;
  

•                anx7866_in: endpoint {
  

•                    remote-endpoint = <&hdmi0_out>;
  

•                };
  

•            };
  

•            port@1 {
  

•                reg = <1>;
  

•                anx7866_out: endpoint {
  

•                    remote-endpoint = <&panel_in>;
  

•               };
  

•            };
  

•        };
  

•    };
  

• };

-- 2.25.0